Handle editing a video. Or changing which video it's pointing to. Not sure how we want to do this in light of our current inability to change a pdf.
Task 348
-
alex marked a task as done over 3 years ago.
-
duff reassigned a task to alex over 3 years ago.
-
duff added a comment over 3 years ago
We can now edit posts. We also have an event for that case. Back to you Alex, in case you'd like to style the Edit Post event in any way.
-
tim added a comment over 3 years ago
sounds like a good suggestion - how tricky is the model/event side?
-
tim reassigned a task to duff over 3 years ago.
-
alex added a comment over 3 years ago
I think any item should be editable - in full. Including replacing an attached file or replacing a video. The allownace would be to hide the video textare / file uppload part intially behind a link like "replace current pdf?".
The even for ANY edit would simply be:
Tim has edited "xx"
That leaves it to the users to be explicit which is fine I'd say.
-
-
tim reassigned a task to tim over 3 years ago.
-
tim re-opened a task for alex over 3 years ago.
-
duff marked a task as done over 3 years ago.
-
duff added a comment over 3 years ago
I implemented it as suggested and pushed. In implementing it, it does seem a bit weird to me that we've made this exception for the video field and which file is attached when we already allow the title and description to be changed.
I'm certainly in favor of creating events for the editing, but I think it would be fine to allow editing of things even before we have the events.
-
tim added a comment over 3 years ago
we should of course capture the editing title/detail as well... but I think changing the video link is different from changing the title, or adjusting the text (depending on what you do of course - the easiest thing is to spell out to users what it was)
-
alex added a comment over 3 years ago
I think we ought to capture the event - does not need to be fine grained (e.g. distinguish between video or file or text) but should be present for us to present to users/ moderators/ admin - or simply to get some usage data...
-
alex added a comment over 3 years ago
I think we do it just like with the file - NOT for now. Or we need an extra event copy: changed the video "title"
-
tim added a comment over 3 years ago
my feeling is that when we make a change to content on the site, we make an event. we let "editing" slip through (it was initially admin only, but then we broadened it to all).
we now have to decide whether it's best to just let stuff happen and try to catch up on events later, or hold back on any modification features unless we can do the event as well.
-
duff created a task for duff over 3 years ago.
You need to login to add comments.
No account yet? Signup is quick and easy.